Skip to content

fix(pat-tinymce): Ingore english language variant translations.#1506

Draft
thet wants to merge 1 commit intomasterfrom
tinymce-translations--ignore-variants
Draft

fix(pat-tinymce): Ingore english language variant translations.#1506
thet wants to merge 1 commit intomasterfrom
tinymce-translations--ignore-variants

Conversation

@thet
Copy link
Member

@thet thet commented Oct 9, 2025

For english translations, ignore country specific language varants. This fixes a probem which occured with a language variant as portal language.

TODO: verify! but I can't remember anymore.

@thet thet marked this pull request as draft October 9, 2025 22:45
@petschki
Copy link
Member

I quickly created a Classic-UI Site with en-us as portal language and TinyMCE worked well... not sure if there are some corner cases though. But this change hardens language negotiation anyways and can be merged in my opinion.

@petschki petschki force-pushed the tinymce-translations--ignore-variants branch from 9e363ae to 101f4f4 Compare March 11, 2026 16:25
@petschki

This comment was marked as outdated.

2 similar comments
@petschki

This comment was marked as outdated.

@petschki

This comment was marked as outdated.

For english translations, ignore country specific language varants.
This fixes a probem which occured with a language variant as portal
language.

TODO: verify! but I can't remember anymore.
@petschki petschki force-pushed the tinymce-translations--ignore-variants branch from 101f4f4 to 7836d7f Compare March 12, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants